fix(release): drop blank gap before direct-push commits#23
Conversation
GitHub's generate-notes leaves a blank-line run before the trailing "Full Changelog" line. The awk that splices direct-push commits in ran after those blanks were already printed, so the commits landed below the gap with another blank added after them — producing a multi-line hole between the PR list and the direct-push commits in both the Release page and the Sparkle update window. Buffer blank lines instead of printing them as they arrive: at the splice point, drop the buffered run, emit the commits flush against the last PR bullet, then exactly one blank line before the section. Blank runs elsewhere are flushed verbatim, so only the pre-splice gap is normalized. Signed-off-by: Kevin Cui <bh@bugs.cc>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThe inline 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Comment |
1 participant
GitHub's generate-notes leaves a blank-line run before the trailing "Full Changelog" line. The awk that splices direct-push commits in ran after those blanks were already printed, so the commits landed below the gap with another blank added after them — producing a multi-line hole between the PR list and the direct-push commits in both the Release page and the Sparkle update window.
Buffer blank lines instead of printing them as they arrive: at the splice point, drop the buffered run, emit the commits flush against the last PR bullet, then exactly one blank line before the section. Blank runs elsewhere are flushed verbatim, so only the pre-splice gap is normalized.